linux-kernel - RE: [PATCH 1/1] TPM: STMicroelectronics ST33 I2C V1.2.0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <35286B1AE75A7C47BFF0870081A31B4B38772D1927@SAFEX1MAIL4.st.com>
Date:	Mon, 12 Nov 2012 10:26:31 +0100
From:	Mathias LEBLANC <Mathias.LEBLANC@...com>
To:	Rusty Russell <rusty@...abs.org>,
	Kent Yoder <key@...ux.vnet.ibm.com>,
	Rajiv Andrade <mail@...jiv.net>,
	Marcel Selhorst <tpmdd@...horst.net>,
	Sirrix AG <tpmdd@...rix.com>,
	"tpmdd-devel@...ts.sourceforge.net" 
	<tpmdd-devel@...ts.sourceforge.net>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Jean-Luc BLANC <jean-luc.blanc@...com>
Subject: RE: [PATCH 1/1] TPM: STMicroelectronics ST33 I2C V1.2.0

Variable interrupts value must be 0 or 1. This restriction is defined by the fact of using the bool parameter (true or false)

Regards,

Mathias Leblanc
________________________________________
From: Rusty Russell [rusty@...abs.org]
Sent: 08 November 2012 13:18
To: Mathias LEBLANC; Kent Yoder; Rajiv Andrade; Marcel Selhorst; Sirrix AG; tpmdd-devel@...ts.sourceforge.net
Cc: linux-kernel@...r.kernel.org; Jean-Luc BLANC; Mathias LEBLANC
Subject: Re: [PATCH 1/1] TPM: STMicroelectronics ST33 I2C V1.2.0

Mathias Leblanc <mathias.leblanc@...com> writes:
> +static int interrupts ;
> +module_param(interrupts, bool, 0444);
> +MODULE_PARM_DESC(interrupts, "Enable interrupts");
> +
> +static int power_mgt = 1;
> +module_param(power_mgt, bool, 0444);
> +MODULE_PARM_DESC(power_mgt, "Power Management");

These are not bools, so why does module_param describe them as bool?

Cheers,
Rusty.--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/