linux-kernel - Re: [PATCH] spi: make sure all transfer has bits_per

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 12 Nov 2012 11:03:56 +0100
From:	Jonas Gorski <jonas.gorski@...il.com>
To:	Laxman Dewangan <ldewangan@...dia.com>
Cc:	grant.likely@...retlab.ca, broonie@...nsource.wolfsonmicro.com,
	spi-devel-general@...ts.sourceforge.net, swarren@...dia.com,
	linux-kernel@...r.kernel.org,
	Stephen Warren <swarren@...dotorg.org>
Subject: Re: [PATCH] spi: make sure all transfer has bits_per_word set

Hi,

On 9 November 2012 10:06, Laxman Dewangan <ldewangan@...dia.com> wrote:
> When spi client does the spi transfer and does not sets
> the bits_per_word for each transfer then set it as default
> of spi device in spi core before calling low level transfer.

I like that (not that it counts ... )!

> Removing the similar code from spi-tegra20-slink driver as
> it is not required.

Not sure if this should be part of *this* patch.
Also spi-tegra20-slink isn't the only one fixing up the bits_per_word
for transfers, so it would be nice if you could remove it from the
other drivers, too.

In a future patch, maybe even do the same with speed_hz?

Regards
Jonas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/