linux-kernel - Re: [RFC Patch v1 33/55] ARC: ptrace support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201211121351.06023.arnd@arndb.de>
Date:	Mon, 12 Nov 2012 13:51:05 +0000
From:	Arnd Bergmann <arnd@...db.de>
To:	Vineet.Gupta1@...opsys.com
Cc:	linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org,
	tglx@...utronix.de
Subject: Re: [RFC Patch v1 33/55] ARC: ptrace support

On Monday 12 November 2012, Vineet.Gupta1@...opsys.com wrote:
> +       case PTRACE_PEEKUSR:
> +               pos = addr;     /* offset in struct user_regs_struct */
> +               count = 4;      /* 1 register only */
> +               u_addr = (unsigned int __user *)data;
> +               kbuf = NULL;
> +               ret = genregs_get(child, NULL, pos, count, kbuf, u_addr);
> +               break;
> +
> +       case PTRACE_POKEUSR:
> +               pos = addr;     /* offset in struct user_regs_struct */
> +               count = 4;      /* 1 register only */
> +
> +               /* Ideally @data would have abeen a user space buffer, from
> +                * where, we do a copy_from_user.
> +                * However this request only involves one word, which courtesy
> +                * our ABI can be passed in a reg.
> +                * regset interface however expects some buffer to copyin from
> +                */
> +               kbuf = &data;
> +               u_addr = NULL;
> +
> +               ret = genregs_set(child, NULL, pos, count, kbuf, u_addr);
> +               break;
> +

I think these should be moved into regsets, as we have done for all
other new architectures. Your arch_ptrace then becomes a trivial wrapper
around ptrace_request.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/