linux-kernel - Re: [REGRESSION] 3.7-rc3+git hard lockup on CPU after inserting/removing USB stick

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <201211121527.02007.Martin@lichtvoll.de>
Date:	Mon, 12 Nov 2012 15:27:01 +0100
From:	Martin Steigerwald <Martin@...htvoll.de>
To:	"Liu, Chuansheng" <chuansheng.liu@...el.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>
Subject: Re: [REGRESSION] 3.7-rc3+git hard lockup on CPU after inserting/removing USB stick

Am Sonntag, 11. November 2012 schrieb Liu, Chuansheng:
> > The first bad commit is:
> > 
> > commit 73d4066055e0e2830533041f4b91df8e6e5976ff
> > Author: Chuansheng Liu <chuansheng.liu@...el.com>
> > Date:   Tue Sep 11 16:00:30 2012 +0800
> > 
> >     USB/host: Cleanup unneccessary irq disable code
> > 
> >     Because the IRQF_DISABLED as the flag is now a NOOP and has been
> >     deprecated and in hardirq context the interrupt is disabled.
> > 
> >     so in usb/host code:
> >     Removing the usage of flag IRQF_DISABLED;
> >     Removing the calling local_irq save/restore actions in irq
> >     handler usb_hcd_irq();
> > 
> >     Signed-off-by: liu chuansheng <chuansheng.liu@...el.com>
> >     Acked-by: Alan Stern <stern@...land.harvard.edu>
> >     Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > 
> > 
> > But:
> > 
> > This ony happens with threadirqs option!
> > 
> > When I remove threadirqs from kernel command line and reboot with this
> > last bisect kernel USB sticks work.
> > 
> > That may explain why nobody else has seen this.
> > 
> > So I will try a 3.7-rc4 now, but without threadirqs enabled.
> > 
> Thanks your pointing out, the USB HCD irq handler is designed to execute in irq handler with irq disabled.
> When threadirqs is in commandline, it will be executed in thread context with local irq enabling, which causes
> this hardlockup.
> 
> I prepared one patch, could you have time to test it? Thanks. Sorry for missing threadirqs case.
> 
> From: liu chuansheng <chuansheng.liu@...el.com>
> Subject: [PATCH] USB/host: Mark USB HCD irq as non-threaded
> 
> Mark USB HCD irq as non-threaded. This prevent one crash/hard lockup
> when "threadirqs" is on the kernel commandline.
> And this interrupt handle is handling critial events which should not
> be in thread context.
> 
> Signed-off-by: liu chuansheng <chuansheng.liu@...el.com>
> ---
>  drivers/usb/core/hcd.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
> index 1e741bc..b1cd46e 100644
> --- a/drivers/usb/core/hcd.c
> +++ b/drivers/usb/core/hcd.c
> @@ -2349,7 +2349,7 @@ static int usb_hcd_request_irqs(struct usb_hcd *hcd,
>         if (hcd->driver->irq) {
>                 snprintf(hcd->irq_descr, sizeof(hcd->irq_descr), "%s:usb%d",
>                                 hcd->driver->description, hcd->self.busnum);
> -               retval = request_irq(irqnum, &usb_hcd_irq, irqflags,
> +               retval = request_irq(irqnum, &usb_hcd_irq, irqflags|IRQF_NO_THREAD,
>                                 hcd->irq_descr, hcd);
>                 if (retval != 0) {
>                         dev_err(hcd->self.controller,
> 

3.7-rc5 with manually patched to

martin@...kaba:~/Computer/Merkaba/Kernel/linux-2.6> git diff drivers | cat
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index 1e741bc..b1cd46e 100644
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hcd.c
@@ -2349,7 +2349,7 @@ static int usb_hcd_request_irqs(struct usb_hcd *hcd,
        if (hcd->driver->irq) {
                snprintf(hcd->irq_descr, sizeof(hcd->irq_descr), "%s:usb%d",
                                hcd->driver->description, hcd->self.busnum);
-               retval = request_irq(irqnum, &usb_hcd_irq, irqflags,
+               retval = request_irq(irqnum, &usb_hcd_irq, irqflags|IRQF_NO_THREAD,
                                hcd->irq_descr, hcd);
                if (retval != 0) {
                        dev_err(hcd->self.controller,

(KMail outputs your mail as base64 and cut&paste did not retain tabs.)

gives:

1) with threadirqs enabled: No action at all when inserting USB sticks,
nothing in dmesg.

2) with threadirqs disabled: USB sticks work normal.

So your patch fixed the CPU lockup by disabling USB altogether, when
thread IRQs are active it seems. :) Or I made a mistake while manually
applying your patch. Seems okay to me tough.


PS: I think that thread IRQs for USB based interrupts might not be a good
from another experience I had with an ThinkPad T42 and USB sound card
Sonica Theater. I was not able to have it produce fluent sound with
Phonon Gstreamer or Phonon VLC from Amarok playing back music unless
I disabled threadirqs on that machine as well. Often I just heard a view
seconds of sound at the beginning and then nothing more at all. Works fine
with thread IRQs disabled. At least from VLC backend. Gives about 30% CPU
usage for that interrupt with thread IRQs enabled. Card is USB 1.1 only.

Ciao,
-- 
Martin 'Helios' Steigerwald - http://www.Lichtvoll.de
GPG: 03B0 0D6C 0040 0710 4AFA  B82F 991B EAAC A599 84C7
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/