linux-kernel - Re: [PATCH] mm: use migrate_prep() instead of migrate_prep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <xa1t625azrus.fsf@mina86.com>
Date:	Mon, 12 Nov 2012 17:52:11 +0100
From:	Michal Nazarewicz <mina86@...a86.com>
To:	Marek Szyprowski <m.szyprowski@...sung.com>, linux-mm@...ck.org,
	linaro-mm-sig@...ts.linaro.org, linux-kernel@...r.kernel.org
Cc:	Marek Szyprowski <m.szyprowski@...sung.com>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Mel Gorman <mel@....ul.ie>, Minchan Kim <minchan@...nel.org>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
	SeongHwan Yoon <sunghwan.yun@...sung.com>
Subject: Re: [PATCH] mm: use migrate_prep() instead of migrate_prep_local()

On Mon, Nov 12 2012, Marek Szyprowski wrote:
> __alloc_contig_migrate_range() should use all possible ways to get all the
> pages migrated from the given memory range, so pruning per-cpu lru lists
> for all CPUs is required, regadless the cost of such operation. Otherwise
> some pages which got stuck at per-cpu lru list might get missed by
> migration procedure causing the contiguous allocation to fail.
>
> Reported-by: SeongHwan Yoon <sunghwan.yun@...sung.com>
> Signed-off-by: Marek Szyprowski <m.szyprowski@...sung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@...sung.com>

Acked-by: Michal Nazarewicz <mina86@...a86.com>

> ---
>  mm/page_alloc.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 1bfe2b0..fcb9719 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -5677,7 +5677,7 @@ static int __alloc_contig_migrate_range(struct compact_control *cc,
>  	unsigned int tries = 0;
>  	int ret = 0;
>  
> -	migrate_prep_local();
> +	migrate_prep();
>  
>  	while (pfn < end || !list_empty(&cc->migratepages)) {
>  		if (fatal_signal_pending(current)) {

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +----<email/xmpp: mpn@...gle.com>--------------ooO--(_)--Ooo--

Content of type "application/pgp-signature" skipped