[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20121112115707.r8h545480kg0cgkk-cebfxv@webmail.spamcop.net>
Date: Mon, 12 Nov 2012 11:57:07 -0500
From: Pavel Roskin <proski@....org>
To: Eric Paris <eparis@...isplace.org>
Cc: Al Viro <viro@...iv.linux.org.uk>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
SE-Linux <selinux@...ho.nsa.gov>
Subject: Re: Bisected regression: iterate_fd() selinux change affects flash
plugin
Quoting Eric Paris <eparis@...isplace.org>:
> OMG this +1 -1 stuff is nuts...
>
> iterate_fd passes fd+1 instead of the fd for the file? seriously?
> ewwww. I see how this patch fixes it, but still, wouldn't some magic
> or negative value for no entries found be better than having to
> understand the crazy logics?
I agree. -ENOENT is both magic and negative :)
I tend to think now that iterate_fd() should be rewritten before it's too
late and all its current users should be cross-checked against the
code prior to the introduction of iterate_fd().
--
Regards,
Pavel Roskin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists