linux-kernel - Re: Porting board initialization for fdt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121112080134.GB25465@arwen.pp.htv.fi>
Date:	Mon, 12 Nov 2012 10:01:34 +0200
From:	Felipe Balbi <balbi@...com>
To:	Constantine Shulyupin <const@...elinux.com>
CC:	Felipe Balbi <balbi@...com>, Tony Lindgren <tony@...mide.com>,
	Santosh Shilimkar <santosh.shilimkar@...com>, <nsekhar@...com>,
	<linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-omap@...r.kernel.org>, <linux@....linux.org.uk>,
	<tim.bird@...sony.com>, <pandaboard@...glegroups.com>,
	Keshava Munegowda <keshava_mgowda@...com>
Subject: Re: Porting board initialization for fdt

Hi,

On Mon, Nov 12, 2012 at 12:38:37AM +0200, Constantine Shulyupin wrote:
> What is architecture and the best strategy to port board initialization to fdt?
> 
> Let's see for example omap4_ehci_init and usbhs_bdata @
> arch/arm/mach-omap2/board-omap4panda.c.

before getting rid of platform_data, we need to switch over to proper
frameworks for muxing, clock, etc. In case of EHCI, pinctrl migration is
currently under development by Keshava (in Cc). After that we need to
take a look at platform and see if there are any function pointers in
there, if there are, those need to be removed.

> How to perform board specific initializations?
> Can omap4_ehci_init be converted to probe function of new platform
> driver  omap4_ehci?

yeah, that function is actually wrong. First, that GPIO pin belongs to
the HUB driver, not the EHCI driver.

Second, those clocks belong to the PHY, not EHCI either. Before those
details are cleaned up, we will always have hacky solutions which will
break in one way or another.

When those cleanups are done, conversion to FDT is not a problem at all.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)