linux-kernel - Re: [PATCH] mfd: arizona: Move chip reset to before register patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121113055618.GC18224@opensource.wolfsonmicro.com>
Date:	Tue, 13 Nov 2012 14:56:20 +0900
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
Cc:	sameo@...ux.intel.com, patches@...nsource.wolfsonmicro.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: arizona: Move chip reset to before register patch

On Mon, Nov 12, 2012 at 05:56:48PM +0000, Charles Keepax wrote:
> In the absence of a physical reset line the chip is reset by writing the
> first register, this was done after the register patch was applied which
> negates the settings applied in the register patch.
> 
> This patch moves the reset to take place before the register patch is
> applied.

No, we should never write to the chip until we have successfully
identified it.  Do a sync or similar instead (we should be triggering
this very soon afterwards via runtime PM anyway).

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)