linux-kernel - Re: [PATCH 3/3] PM: Introduce Intel PowerClamp Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1352788416.24230.6.camel@joe-AO722>
Date:	Mon, 12 Nov 2012 22:33:36 -0800
From:	Joe Perches <joe@...ches.com>
To:	Jacob Pan <jacob.jun.pan@...ux.intel.com>
Cc:	Linux PM <linux-pm@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Rafael Wysocki <rafael.j.wysocki@...el.com>,
	Len Brown <len.brown@...el.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...e.hu>,
	Zhang Rui <rui.zhang@...el.com>, Rob Landley <rob@...dley.net>,
	Arjan van de Ven <arjan@...ux.intel.com>,
	Paul McKenney <paulmck@...ux.vnet.ibm.com>
Subject: Re: [PATCH 3/3] PM: Introduce Intel PowerClamp Driver

On Mon, 2012-11-12 at 14:03 -0800, Jacob Pan wrote:
> Intel PowerClamp driver performs synchronized idle injection across
> all online CPUs. The goal is to maintain a given package level C-state
> ratio.

style trivia:

[]

> diff --git a/drivers/thermal/intel_powerclamp.c b/drivers/thermal/intel_powerclamp.c
[]
> +
> +/* #define DEBUG */
> +

Adding this #define before any #include

#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

> +#include <linux/module.h>
> +#include <linux/kernel.h>

[]

> +static int window_size_set(const char *arg, const struct kernel_param *kp)
> +{
[]
> +	if (new_window_size >= 10 || new_window_size < 2) {
> +		pr_err("PowerClamp: invalid window size %lu, between 2-10\n",
> +			new_window_size);

Means there's no need for "PowerClamp: " prefixes with pr_fmt

		pr_err("invalid window size %lu...

and all the other pr_<level> uses get prefixed too.

> +static u64 pkg_state_counter(void)
> +{
> +	u64 val;
> +	u64 count = 0;
> +
> +	static int skip_c2;
> +	static int skip_c3;
> +	static int skip_c6;
> +	static int skip_c7;

bool?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/