linux-kernel - Re: [PATCH 02/46] x86, mm: Split out split_mem_range from init_memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE9FiQVZM9-TuBYZjWsqd58XqGW2tzQbwG3r6R9XfB+9D9_PKQ@mail.gmail.com>
Date:	Tue, 13 Nov 2012 10:34:27 -0800
From:	Yinghai Lu <yinghai@...nel.org>
To:	snakky.zhang@...il.com
Cc:	Yasuaki Ishimatsu <isimatu.yasuaki@...fujitsu.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...e.hu>, "H. Peter Anvin" <hpa@...or.com>,
	Jacob Shin <jacob.shin@....com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Stefano Stabellini <stefano.stabellini@...citrix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/46] x86, mm: Split out split_mem_range from init_memory_mapping

On Mon, Nov 12, 2012 at 11:03 PM,  <snakky.zhang@...il.com> wrote:
> On 2012年11月13日 14:20, Yinghai Lu wrote:
>>> 2012/11/13 6:17, Yinghai Lu wrote:
>>>>
>>>> +     nr_range = 0;
>>>
>>> This is unnecessary since it is set in the below.
>>>
>>>> +     nr_range = split_mem_range(mr, nr_range, start, end);
>>
>>                                                               ^^^^^^^^
>
> Why not use 0 directly?
>
> nr_range = split_mem_range(mr, 0, start, end);

yes, even could remove nr_range from split_mem_range.

but originally try to like "really" chopping the code to two parts.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/