linux-kernel - Re: xfs: Remove boolean

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121113023207.GZ9783@sgi.com>
Date:	Mon, 12 Nov 2012 20:32:07 -0600
From:	Ben Myers <bpm@....com>
To:	Thiago Farina <tfransosi@...il.com>
Cc:	Dave Chinner <david@...morbit.com>, Alex Elder <elder@...nel.org>,
	linux list <linux-kernel@...r.kernel.org>, xfs@....sgi.com
Subject: Re: xfs: Remove boolean_t typedef completely.

Hi Thiago,

On Tue, Nov 13, 2012 at 12:02:14AM -0200, Thiago Farina wrote:
> On Mon, Nov 12, 2012 at 11:53 PM, Dave Chinner <david@...morbit.com> wrote:
> > On Mon, Nov 12, 2012 at 10:36:47PM -0200, Thiago Farina wrote:
> >> On Mon, Nov 12, 2012 at 10:24 PM, Dave Chinner <david@...morbit.com> wrote:
> >> > On Mon, Nov 12, 2012 at 09:36:17PM -0200, Thiago Farina wrote:
> >> >> Hi,
> >> >>
> >> >> Please, take a look.
> >> >>
> >> >> Patch attached.
> >> >
> >> > It's a good start for a cleanup, but there's no point in removing
> >> > the boolean_t from one file and then not removing it from the rest
> >> > of the XFS code.  It's only used in a handful of places, so just
> >> > remove it completely.
> >> >
> >> Done.
> >>
> >> Please, take another look.
> >>
> >> > Also, can you please place patches in line rather than attaching
> >> > them. Attaching them means they cannot be quoted in reply. See
> >> > Documentation/SubmittingPatches and Documentation/email-clients.txt
> >> > for guidelines.
> >> >
> >> Sorry, patch attached.
> >
> > It's still attached as a base64 encoded attachment, not as inline
> > text....
> >
> Yep, sorry about that. Is just a text file from $(git format-patch master);

If you don't mind another try... it would be helpful if you could resend the
patch inline.  It helps to facilitate a discussion of the patch along with your
text should it be necessary.

You're only touching xfs, so you can drop linux-kernel if you want.

Thanks,
	Ben
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/