linux-kernel - Re: [PATCH 1/2] i2c: Add possibility for user-defined (i2c-)devices for bus-drivers.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 13 Nov 2012 19:55:33 +0100
From:	Jean Delvare <khali@...ux-fr.org>
To:	Alexander Holler <holler@...oftware.de>
Cc:	linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
	Till Harbaum <till@...baum.org>
Subject: Re: [PATCH 1/2] i2c: Add possibility for user-defined (i2c-)devices
 for bus-drivers.

On Tue, 13 Nov 2012 19:06:07 +0100, Alexander Holler wrote:
> This makes it possible to define i2c-devices at the kernel command line
> or as a module parameter for bus-drivers which want to offer such
> an functionality.
> 
> Drivers which are using it will have the a parameter named
> devices with format devname1@...r1,devname2@...r2,...
> e.g. devices=ds1307@...8,pcf8563@...1

No, no, no. We did that 10 years ago, killed all the code 3 years ago
[1], let's not do the same mistake again, please. We have a sysfs
interface for instantiating clients dynamically from user-space, it's
way more powerful and flexible than your proposal. Just try plugging two
different i2c-tiny-usb adapters on the same system and see the new code
instantiate the wrong devices...

[1] http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commit;h=7f508118b1c1f9856a1c899a2bd4867a962b0225

> The devices will be probed using the standard probe mechanism,
> the definition of up to 8 devices is allowed.
> 
> Cc: Jean Delvare <khali@...ux-fr.org>
> Cc: Till Harbaum <till@...baum.org>
> Signed-off-by: Alexander Holler <holler@...oftware.de>
> ---
>  Documentation/i2c/instantiating-devices | 37 ++++++++++++++++++++++++++++++
>  drivers/i2c/i2c-core.c                  | 40 +++++++++++++++++++++++++++++++++
>  include/linux/i2c.h                     | 14 ++++++++++++
>  3 files changed, 91 insertions(+)
> (...)

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/