linux-kernel - Re: [PATCH 21/46] x86, mm: setup page table in top-down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 13 Nov 2012 12:01:10 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Yinghai Lu <yinghai@...nel.org>
CC:	Stefano Stabellini <stefano.stabellini@...citrix.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...e.hu>, Jacob Shin <jacob.shin@....com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 21/46] x86, mm: setup page table in top-down

On 11/13/2012 11:59 AM, Yinghai Lu wrote:
>>
>> The changes to init_mem_mapping are a bit iffy but they aren't too
>> unreasonable.
>> Overall the patch is OK even though I would certainly appreciate more
>> comments and better variable names (real_end?), see below.
> 
> real_end is not good?
> 
> xen put big reserved range between real_end and end.
> 
> that real_end is some kind of end of real usable areas.
> 
> so change to real_usable_end  or usable_end?
> 

A description of a variable that includes the words "some kind of"
clearly indicates major confusion.  We need to know what the semantics
are, here.

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/