linux-kernel - Re: [PATCH] tilegx: request_irq with a non-null device name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121113135016.229e2571@nehalam.linuxnetplumber.net>
Date:	Tue, 13 Nov 2012 13:50:16 -0800
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Chris Metcalf <cmetcalf@...era.com>
Cc:	Simon Marchi <simon.marchi@...ymtl.ca>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tilegx: request_irq with a non-null device name

On Tue, 13 Nov 2012 16:37:11 -0500
Chris Metcalf <cmetcalf@...era.com> wrote:

> On 11/13/2012 3:58 PM, Simon Marchi wrote:
> > This patch simply makes the tilegx net driver call request_irq with a
> > non-null name. It makes the output in /proc/interrupts more obvious, but
> > also helps tools that don't expect to find null there.
> >
> > Signed-off-by: Simon Marchi <simon.marchi@...ymtl.ca>
> > ---
> >  drivers/net/ethernet/tile/tilegx.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/tile/tilegx.c b/drivers/net/ethernet/tile/tilegx.c
> > index 4e98100..66e025a 100644
> > --- a/drivers/net/ethernet/tile/tilegx.c
> > +++ b/drivers/net/ethernet/tile/tilegx.c
> > @@ -917,7 +917,7 @@ static int tile_net_setup_interrupts(struct net_device *dev)
> >  	ingress_irq = rc;
> >  	tile_irq_activate(ingress_irq, TILE_IRQ_PERCPU);
> >  	rc = request_irq(ingress_irq, tile_net_handle_ingress_irq,
> > -			 0, NULL, NULL);
> > +			 0, "tile_net", NULL);
> 
> Good catch.  If you can change it to dev->name instead of "tile_net", feel
> free to add my:
> 
> Acked-by: Chris Metcalf <cmetcalf@...era.com>
> 

It really should be using dev->name since that helps out some
applications like irqbalance that read /proc/interrupts
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/