linux-kernel - Re: [PATCH 1/2] i2c: Add possibility for user-defined (i2c-)devices for bus-drivers.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50A35F77.8060901@ahsoftware.de>
Date:	Wed, 14 Nov 2012 10:08:07 +0100
From:	Alexander Holler <holler@...oftware.de>
To:	Jean Delvare <khali@...ux-fr.org>
CC:	linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
	Till Harbaum <till@...baum.org>
Subject: Re: [PATCH 1/2] i2c: Add possibility for user-defined (i2c-)devices
 for bus-drivers.

Am 14.11.2012 03:47, schrieb Alexander Holler:
> Hello,
>
> Am 13.11.2012 22:42, schrieb Jean Delvare:
>
>> Plus you don't address the main issues. Your syntax gives you no way to
>> support two i2c-tiny-usb adapters with different chips at a specific
>> address. The sysfs interface supports such a setup. Also instantiating
>> the wrong devices is worse than instating a device that doesn't exist
>> at all. So the use of i2c_new_probed_device() here will randomly help
>> in a limited number of cases and randomly be problematic in others.
>> Hard to justify...
>
> As you seem to have a solution for multiple devices of the same type by
> using sysfs, how to do you decide which one to use? You might be able to
> probe just one, but my simple mind currently doesn't come up with a
> solution which device one has to probe. Just because I'm curious... ;)

And while we are at artificial problems, I've just seen a small problem 
in my patch which might occur if someone really uses two of those 
devices. I've already fixed it here, but until one of you gives me the 
ok for inclusion into the mainline, I don't want to waste more of your 
valuable time with posting a corrected patch for something no one of you 
wants.

Regards,

Alexander
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/