linux-kernel - Re: [PATCH] mfd: arizona: Move chip reset to before register patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121114105106.GK7407@opensource.wolfsonmicro.com>
Date:	Wed, 14 Nov 2012 19:51:08 +0900
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
Cc:	sameo@...ux.intel.com, patches@...nsource.wolfsonmicro.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: arizona: Move chip reset to before register patch

On Wed, Nov 14, 2012 at 10:48:54AM +0000, Charles Keepax wrote:
> On Wed, Nov 14, 2012 at 10:20:09AM +0900, Mark Brown wrote:

> > Just do a sync, make sure that we mark the map as dirty when we do the
> > reset via register write and it'll not have any effect anyway.  We
> > should also check if we've got the LDO and use that for reset too
> > actually...

> The way the code is layed out at the moment if we don't
> successfully get the LDO we won't get as far as the register
> write reset. Meaning that if we can do the reset by cycling the
> power on the LDO is there any point in having the option to do
> the reset via a register write later?

No, we can't rely on having control over the LDO - it might be always
on.  But we should ideally try to use it as a fallback, using a notifier
to find out if that worked or not.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)