linux-kernel - Re: [PATCH] staging: dgrp: dgrp_tty.c: return an -EFAULT if get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121114115532.5b4fa80d@pyramind.ukuu.org.uk>
Date:	Wed, 14 Nov 2012 11:55:32 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Kumar Amit Mehta <gmate.amit@...il.com>
Cc:	gregkh@...uxfoundation.org, wfp5p@...ginia.edu,
	geert@...ux-m68k.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] staging: dgrp: dgrp_tty.c: return an -EFAULT if
 get_user() fails

On Wed, 14 Nov 2012 13:11:18 +0530
Kumar Amit Mehta <gmate.amit@...il.com> wrote:

> Inspect the return value of get_user() and return -EFAULT on error.

You cam just delete all the TIOCSOFTCAR nonsense. That ioctl is handled
correctly by the core tty layer code rather than incorrectly by the dgrp
driver.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/