linux-kernel - Re: [patch 3/7] fs, notify: Add file handle entry into inotify_inode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121114133253.GM16685@moon>
Date:	Wed, 14 Nov 2012 17:32:53 +0400
From:	Cyrill Gorcunov <gorcunov@...nvz.org>
To:	"J. Bruce Fields" <bfields@...ldses.org>
Cc:	Pavel Emelyanov <xemul@...allels.com>,
	Tvrtko Ursulin <tvrtko.ursulin@...lan.co.uk>,
	David Rientjes <rientjes@...gle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	Al Viro <viro@...iv.linux.org.uk>,
	Alexey Dobriyan <adobriyan@...il.com>,
	James Bottomley <jbottomley@...allels.com>,
	Matthew Helsley <matt.helsley@...il.com>,
	aneesh.kumar@...ux.vnet.ibm.com
Subject: Re: [patch 3/7] fs, notify: Add file handle entry into
 inotify_inode_mark

On Wed, Nov 14, 2012 at 08:26:22AM -0500, J. Bruce Fields wrote:
> On Wed, Nov 14, 2012 at 05:03:47PM +0400, Cyrill Gorcunov wrote:
> > On Wed, Nov 14, 2012 at 07:45:49AM -0500, J. Bruce Fields wrote:
> > > > 
> > > > We can try going this route, what do you think?
> > > 
> > > I still don't understand why you need a dentry to get the filehandle.
> > > The current api may ask for one, but it shouldn't really be necessary
> > > (assuming you don't want parent directory information encoded in the
> > > filehandle, which I hope you don't).
> > 
> > As far as I know we don't need parent encoded. So Bruce, you think
> > to modify exportfs instead to work with inode directly?
> 
> Looks like the filesystem encode_fh method just takes inodes (with the
> parent inode allowed to be NULL), so all you'd need would be a version
> of exportfs_encode_fh that took an inode.
> 
> (Worst case, if that didn't work, you could fake up a dentry with
> something like d_obtain_alias, but better not to if it's not necessary.)

Yeah, I'll update the series, test it and show ther results. Thanks!

	Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/