linux-kernel - Re: [PATCH 1/3] staging: line6: replace DEBUG_MESSAGES() with dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121114144041.GI11515@mwanda>
Date:	Wed, 14 Nov 2012 17:40:41 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Stefan Hajnoczi <stefanha@...il.com>
Cc:	devel@...verdev.osuosl.org, line6linux-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, Daniel Mack <zonque@...il.com>,
	Markus Grabner <grabner@....tugraz.at>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 1/3] staging: line6: replace DEBUG_MESSAGES() with
 dev_dbg()

On Sun, Nov 11, 2012 at 01:52:24PM +0100, Stefan Hajnoczi wrote:
> +					dev_dbg(pod->line6.ifcdev,
> +						"wrong size of channel dump message (%d instead of %d)\n",
> +						pod->line6.message_length,
> +						(int)sizeof(pod->prog_data) +
> +						7);

Better to get rid of the cast.  You're already over the 80 character
limit so putting the "7);" on the line before is ok.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/