linux-kernel - Re: [PATCH 1/2] ARM: tegra: Add Tegra20 host1x support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121114150125.GA11050@avionic-0098.mockup.avionic-design.de>
Date:	Wed, 14 Nov 2012 16:01:25 +0100
From:	Thierry Reding <thierry.reding@...onic-design.de>
To:	Terje Bergström <tbergstrom@...dia.com>
Cc:	Stephen Warren <swarren@...dotorg.org>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] ARM: tegra: Add Tegra20 host1x support

On Wed, Nov 14, 2012 at 10:35:31AM +0200, Terje Bergström wrote:
> On 09.11.2012 15:20, Thierry Reding wrote:
> > This commit adds the host1x node along with its children to the Tegra20
> > DTSI. Furthermore the OF auxiliary data table is updated to have proper
> > names assigned to the platform devices instantiated from the device
> > tree. Moreover, the clocks required by host1x and the two display
> > controllers are initialized and the pll_d frequency table is completed
> > with a few entries to support common HDMI and LVDS display modes.
> 
> I tried to add nvhost on top of your patches and I noticed a glitch.
> 
> > +       { "host1x",     "pll_c",        144000000,      false },
> 
> This line causes host1x not to operate correctly. I don't know why this
> is so, but when I try to initialize host1x, it hangs with this change,
> but everything works without this line.
> 
> If you could fix that,

Funny. I just tested with this line removed and I also get the freeze.
With the line I don't get the freeze. Does the freeze only occur with
additional patches on top? If so I think we should keep the line in for
now because it is what most people have tested against and which has
proven to work. We can fix any remaining issues with host1x specific
things when actual patches emerge.

Thierry

Content of type "application/pgp-signature" skipped