linux-kernel - Re: [PATCH v2] staging: dgrp: dgrp_tty.c: return an -EFAULT if put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 14 Nov 2012 20:55:12 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Kumar Amit Mehta <gmate.amit@...il.com>
Cc:	alan@...rguk.ukuu.org.uk, gregkh@...uxfoundation.org,
	wfp5p@...ginia.edu, geert@...ux-m68k.org,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH v2] staging: dgrp: dgrp_tty.c: return an -EFAULT if
 put_user fails

On Wed, Nov 14, 2012 at 05:07:37PM +0530, Kumar Amit Mehta wrote:
> Inspect the return value of put_user() and return -EFAULT on error.
> 
> Signed-off-by: Kumar Amit Mehta <gmate.amit@...il.com>
> ---
>  drivers/staging/dgrp/dgrp_tty.c |   10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/dgrp/dgrp_tty.c b/drivers/staging/dgrp/dgrp_tty.c
> index e125b03..cebd3a1 100644
> --- a/drivers/staging/dgrp/dgrp_tty.c
> +++ b/drivers/staging/dgrp/dgrp_tty.c
> @@ -2265,9 +2265,7 @@ static int get_modem_info(struct ch_struct *ch, unsigned int *value)
>  		| ((mlast & DM_RI)  ? TIOCM_RNG : 0)
>  		| ((mlast & DM_DSR) ? TIOCM_DSR : 0)
>  		| ((mlast & DM_CTS) ? TIOCM_CTS : 0);
> -	put_user(mlast, (unsigned int __user *) value);
> -
> -	return 0;
> +	return put_user(mlast, (unsigned int __user *) value);
>  }
>  
>  /*
> @@ -2620,7 +2618,8 @@ static int dgrp_tty_ioctl(struct tty_struct *tty, unsigned int cmd,
>  			       sizeof(long));
>  		if (rc == 0)
>  			return -EFAULT;
> -		put_user(C_CLOCAL(tty) ? 1 : 0, (unsigned long __user *) arg);
> +		if (put_user(C_CLOCAL(tty) ? 1 : 0, (unsigned long __user *) arg))
> +			return -EFAULT;
>  		return 0;

This one could just be return put_user() as well.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/