linux-kernel - Re: [PATCH] drivers/of: Constify device_node->name and ->path_component

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20121114.174938.1893866220809474233.davem@davemloft.net>
Date:	Wed, 14 Nov 2012 17:49:38 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	grant.likely@...retlab.ca
Cc:	linux-kernel@...r.kernel.org, devicetree-discuss@...ts.ozlabs.org,
	sparclinux@...r.kernel.org, benh@...nel.crashing.org
Subject: Re: [PATCH] drivers/of: Constify device_node->name and
 ->path_component_name

From: Grant Likely <grant.likely@...retlab.ca>
Date: Wed, 14 Nov 2012 22:42:26 +0000

> On Wed, Nov 14, 2012 at 10:33 PM, David Miller <davem@...emloft.net> wrote:
>>
>> You're making other changes here, such as the kstrdup() stuff,
>> seperate that into another patch.
> 
> It's part of the same change. The original code was allocating a
> buffer, saving the pointer in the name field and then modifying it.
> Making the code to a kstrdup() gets rid of modifying the const buffer.

Please mention that in your commit message then, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/