linux-kernel - Re: [PATCH v5 11/11] thp, vmstat: implement HZP_ALLOC and HZP_ALLOC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1211141541000.22537@chino.kir.corp.google.com>
Date:	Wed, 14 Nov 2012 15:41:53 -0800 (PST)
From:	David Rientjes <rientjes@...gle.com>
To:	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Andrea Arcangeli <aarcange@...hat.com>, linux-mm@...ck.org,
	Andi Kleen <ak@...ux.intel.com>,
	"H. Peter Anvin" <hpa@...ux.intel.com>,
	linux-kernel@...r.kernel.org,
	"Kirill A. Shutemov" <kirill@...temov.name>
Subject: Re: [PATCH v5 11/11] thp, vmstat: implement HZP_ALLOC and HZP_ALLOC_FAILED
 events

On Wed, 7 Nov 2012, Kirill A. Shutemov wrote:

> From: "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
> 
> hzp_alloc is incremented every time a huge zero page is successfully
> 	allocated. It includes allocations which where dropped due
> 	race with other allocation. Note, it doesn't count every map
> 	of the huge zero page, only its allocation.
> 
> hzp_alloc_failed is incremented if kernel fails to allocate huge zero
> 	page and falls back to using small pages.
> 

Nobody is going to know what hzp_ is, sorry.  It's better to be more 
verbose and name them what they actually are: THP_ZERO_PAGE_ALLOC and 
THP_ZERO_PAGE_ALLOC_FAILED.  But this would assume we want to lazily 
allocate them, which I disagree with hpa about.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/