linux-kernel - RE: [PATCH] backlight: pandora_bl: Change TWL4030_MODULE_PWM0 to TWL_MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <003f01cdc2ca$9a9bb350$cfd319f0$%han@samsung.com>
Date:	Thu, 15 Nov 2012 09:46:09 +0900
From:	Jingoo Han <jg1.han@...sung.com>
To:	'Peter Ujfalusi' <peter.ujfalusi@...com>,
	'Andrew Morton' <akpm@...ux-foundation.org>
Cc:	'Richard Purdie' <rpurdie@...ys.net>,
	'Florian Tobias Schandinat' <FlorianSchandinat@....de>,
	linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	'Grazvydas Ignotas' <notasas@...il.com>
Subject: RE: [PATCH] backlight: pandora_bl: Change TWL4030_MODULE_PWM0 to
 TWL_MODULE_PWM

On Wednesday, November 14, 2012 8:16 PM Peter Ujfalusi wrote
> 
> TWL_MODULE_PWM is defined as:
> #define TWL_MODULE_PWM		TWL4030_MODULE_PWM0
> 
> Use the common module ID define here which will facilitate the upcoming
> twl-core cleanup.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@...com>

CC'ed Andrew Morton

It looks good.

Acked-by: Jingoo Han <jg1.han@...sung.com>


> ---
>  drivers/video/backlight/pandora_bl.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/video/backlight/pandora_bl.c b/drivers/video/backlight/pandora_bl.c
> index 4ec3074..633b0a2 100644
> --- a/drivers/video/backlight/pandora_bl.c
> +++ b/drivers/video/backlight/pandora_bl.c
> @@ -71,8 +71,7 @@ static int pandora_backlight_update_status(struct backlight_device *bl)
>  		 * set PWM duty cycle to max. TPS61161 seems to use this
>  		 * to calibrate it's PWM sensitivity when it starts.
>  		 */
> -		twl_i2c_write_u8(TWL4030_MODULE_PWM0, MAX_VALUE,
> -					TWL_PWM0_OFF);
> +		twl_i2c_write_u8(TWL_MODULE_PWM, MAX_VALUE, TWL_PWM0_OFF);
> 
>  		/* first enable clock, then PWM0 out */
>  		twl_i2c_read_u8(TWL4030_MODULE_INTBR, &r, TWL_INTBR_GPBR1);
> @@ -90,8 +89,7 @@ static int pandora_backlight_update_status(struct backlight_device *bl)
>  		usleep_range(2000, 10000);
>  	}
> 
> -	twl_i2c_write_u8(TWL4030_MODULE_PWM0, MIN_VALUE + brightness,
> -				TWL_PWM0_OFF);
> +	twl_i2c_write_u8(TWL_MODULE_PWM, MIN_VALUE + brightness, TWL_PWM0_OFF);
> 
>  done:
>  	if (brightness != 0)
> @@ -132,7 +130,7 @@ static int pandora_backlight_probe(struct platform_device *pdev)
>  	platform_set_drvdata(pdev, bl);
> 
>  	/* 64 cycle period, ON position 0 */
> -	twl_i2c_write_u8(TWL4030_MODULE_PWM0, 0x80, TWL_PWM0_ON);
> +	twl_i2c_write_u8(TWL_MODULE_PWM, 0x80, TWL_PWM0_ON);
> 
>  	bl->props.state |= PANDORABL_WAS_OFF;
>  	bl->props.brightness = MAX_USER_VALUE;
> --
> 1.8.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/