linux-kernel - Re: [PATCH 3/6] perf ui/gtk: Implement ui

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 15 Nov 2012 09:47:23 +0200 (EET)
From:	Pekka Enberg <penberg@...nel.org>
To:	Namhyung Kim <namhyung@...nel.org>
cc:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Namhyung Kim <namhyung.kim@....com>
Subject: Re: [PATCH 3/6] perf ui/gtk: Implement ui_progress functions

On Tue, 13 Nov 2012, Namhyung Kim wrote:
> From: Namhyung Kim <namhyung.kim@....com>
> 
> Implement progress update function for GTK2 front end.
> 
> Note that since it will be called before gtk main loop so that
> we should call gtk event loop handler directly.
> 
> Cc: Pekka Enberg <penberg@...nel.org>
> Signed-off-by: Namhyung Kim <namhyung@...nel.org>

> diff --git a/tools/perf/ui/gtk/progress.c b/tools/perf/ui/gtk/progress.c
> new file mode 100644
> index 000000000000..903426fe27cf
> --- /dev/null
> +++ b/tools/perf/ui/gtk/progress.c
> @@ -0,0 +1,50 @@
> +#include <inttypes.h>
> +
> +#include "gtk.h"
> +#include "../progress.h"
> +#include "util.h"
> +
> +static GtkWidget *dialog;
> +static GtkWidget *progress;
> +
> +static void gtk_progress_update(u64 curr, u64 total, const char *title)
> +{
> +	double fraction = total ? 1.0 * curr / total : 0.0;
> +	char buf[1024];
> +
> +	if (dialog == NULL) {
> +		GtkWidget *vbox = gtk_vbox_new(TRUE, 5);
> +		GtkWidget *label = gtk_label_new(title);
> +
> +		dialog = gtk_window_new(GTK_WINDOW_TOPLEVEL);
> +		progress = gtk_progress_bar_new();
> +
> +		gtk_box_pack_start(GTK_BOX(vbox), label, TRUE, FALSE, 3);
> +		gtk_box_pack_start(GTK_BOX(vbox), progress, TRUE, TRUE, 3);
> +
> +		gtk_container_add(GTK_CONTAINER(dialog), vbox);
> +
> +		gtk_window_set_title(GTK_WINDOW(dialog), "perf");
> +		gtk_window_resize(GTK_WINDOW(dialog), 300, 80);
> +		gtk_window_set_position(GTK_WINDOW(dialog), GTK_WIN_POS_CENTER);
> +
> +		gtk_widget_show_all(dialog);
> +	}
> +
> +	gtk_progress_bar_set_fraction(GTK_PROGRESS_BAR(progress), fraction);
> +	snprintf(buf, sizeof(buf), "%"PRIu64" / %"PRIu64, curr, total);
> +	gtk_progress_bar_set_text(GTK_PROGRESS_BAR(progress), buf);
> +
> +	/* we didn't call gtk_main yet, so do it manually */
> +	while (gtk_events_pending())
> +		gtk_main_iteration();
> +}

When is the progress bar shown? Why does it need to be a separate dialog? 
Can't we embed it in the current perf window (and make the other 
UI components disabled if necessary)?

			Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/