linux-kernel - Re: [PATCH v2] cuse: do not register multiple devices with the same name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121115144404.GA7306@mtj.dyndns.org>
Date:	Thu, 15 Nov 2012 06:44:04 -0800
From:	Tejun Heo <tj@...nel.org>
To:	David Herrmann <dh.herrmann@...glemail.com>
Cc:	fuse-devel@...ts.sourceforge.net,
	Miklos Szeredi <miklos@...redi.hu>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] cuse: do not register multiple devices with the same
 name

On Thu, Nov 15, 2012 at 01:23:17PM +0100, David Herrmann wrote:
> We do not check whether we already registered a CUSE device with a given
> name so we might end up with two devices with the same name. Sysfs will
> then complain as it cannot create suitable directories.
> 
> This patch makes the init-command fail if there is already a device with
> the given name. To avoid race-conditions, we protect the whole
> registration with a mutex now.
> 
> Following the sysfs warnings when registering two devices with the same
> name:
...
> Signed-off-by: David Herrmann <dh.herrmann@...glemail.com>

Acked-by: Tejun Heo <tj@...nel.org>

But it probably would be better to separate out mutex conversion as a
separate patch.

Thanks!

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/