lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 15 Nov 2012 17:17:27 +0200 From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> To: viresh kumar <viresh.kumar@...aro.org> Cc: Vinod Koul <vinod.koul@...el.com>, spear-devel <spear-devel@...t.st.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/2] dw_dmac: check direction properly in dw_dma_cyclic_prep On Thu, 2012-11-15 at 20:28 +0530, viresh kumar wrote: > On Thu, Nov 15, 2012 at 8:05 PM, viresh kumar <viresh.kumar@...aro.org> wrote: > > On Thu, Nov 15, 2012 at 7:50 PM, Andy Shevchenko > > <andriy.shevchenko@...ux.intel.com> wrote: > >> diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c > > > >> +static inline bool is_slave_direction(enum dma_transfer_direction direction) > >> +{ > >> + return (direction == DMA_MEM_TO_DEV) || (direction == DMA_DEV_TO_MEM); > >> +} > > > > I would add this in dmaengine.h and will also include check for DMA_DEV_TO_DEV. > > Also, what about is_slave_xfer() name? No objections. -- Andy Shevchenko <andriy.shevchenko@...ux.intel.com> Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists