[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87y5i23jp4.fsf@dell.be.48ers.dk>
Date: Thu, 15 Nov 2012 17:38:31 +0100
From: Peter Korsgaard <jacmet@...site.dk>
To: Andreas Larsson <andreas@...sler.com>
Cc: Wolfram Sang <w.sang@...gutronix.de>,
Ben Dooks <ben-linux@...ff.org>, linux-i2c@...r.kernel.org,
Grant Likely <grant.likely@...retlab.ca>,
devicetree-discuss@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
software@...sler.com
Subject: Re: [PATCH v6 2/2] i2c: i2c-ocores: Add support for the GRLIB port of the controller and use function pointers for getreg and setreg functions
>>>>> "Andreas" == Andreas Larsson <andreas@...sler.com> writes:
Andreas> The registers in the GRLIB port of the controller are 32-bit
Andreas> and in big endian byte order. The PRELOW and PREHIGH registers
Andreas> are merged into one register. The subsequent registers have
Andreas> their offset decreased accordingly. Hence the register access
Andreas> needs to be handled in a non-standard manner using custom
Andreas> getreg and setreg functions.
Andreas> Add setreg and getreg functions for different register widths
Andreas> and let oc_setreg and oc_getreg use function pointers to call
Andreas> the appropriate functions.
Andreas> A type is added as the data of the of match table entries. A
Andreas> new entry with a different compatible string is added to the
Andreas> table. The type of that entry triggers usage of the custom
Andreas> grlib functions by setting the setreg and getreg function
Andreas> pointers.
Andreas> Signed-off-by: Andreas Larsson <andreas@...sler.com>
Acked-by: Peter Korsgaard <jacmet@...site.dk>
Thanks!
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists