linux-kernel - Re: [ 27/82] gpiolib: Dont return -EPROBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1353009986.4867.70.camel@deadeye.wl.decadent.org.uk>
Date:	Thu, 15 Nov 2012 20:06:26 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Herton Ronaldo Krzesinski <herton.krzesinski@...onical.com>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	akpm@...ux-foundation.org, alan@...rguk.ukuu.org.uk,
	Mathias Nyman <mathias.nyman@...ux.intel.com>,
	Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [ 27/82] gpiolib: Dont return -EPROBE_DEFER to sysfs, or for
 invalid gpios

On Thu, 2012-11-15 at 15:52 -0200, Herton Ronaldo Krzesinski wrote:
> On Wed, Nov 14, 2012 at 05:40:00AM +0000, Ben Hutchings wrote:
> > 3.2-stable review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Mathias Nyman <mathias.nyman@...ux.intel.com>
> > 
> > commit ad2fab36d7922401c4576fb7ea9b21a47a29a17f upstream.
> > 
> > gpios requested with invalid numbers, or gpios requested from userspace via sysfs
> > should not try to be deferred on failure.
> > 
> > Signed-off-by: Mathias Nyman <mathias.nyman@...ux.intel.com>
> > Signed-off-by: Linus Walleij <linus.walleij@...aro.org>
> > Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
> > ---
> >  drivers/gpio/gpiolib.c |   10 +++++++---
> >  1 file changed, 7 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> > index 5d6c71e..1c8d9e3 100644
> > --- a/drivers/gpio/gpiolib.c
> > +++ b/drivers/gpio/gpiolib.c
> > @@ -623,9 +623,11 @@ static ssize_t export_store(struct class *class,
> >  	 */
> >  
> >  	status = gpio_request(gpio, "sysfs");
> > -	if (status < 0)
> > +	if (status < 0) {
> > +		if (status == -EPROBE_DEFER)
> 
> This one fails to build here:
> linux/drivers/gpio/gpiolib.c: In function 'export_store':
> linux/drivers/gpio/gpiolib.c:625:18: error: 'EPROBE_DEFER' undeclared (first use in this function)
> linux/drivers/gpio/gpiolib.c:625:18: note: each undeclared identifier is reported only once for each function it appears in
>
> There is no EPROBE_DEFER functionality on 3.2 and in gpio_request, so I
> think the patch can be safely dropped.
> 
> [...]

Right, I'll do that, thanks.

Ben.

-- 
Ben Hutchings
friends: People who know you well, but like you anyway.

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)