linux-kernel - Re: [PATCH] MIPS: Fix crash that occurs when function tracing is enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 15 Nov 2012 15:30:54 -0800
From:	David Daney <ddaney.cavm@...il.com>
To:	Al Cooper <alcooperx@...il.com>
CC:	ralf@...ux-mips.org, linux-mips@...ux-mips.org,
	linux-kernel@...r.kernel.org, cernekee@...il.com
Subject: Re: [PATCH] MIPS: Fix crash that occurs when function tracing is
 enabled

On 11/15/2012 03:16 PM, Al Cooper wrote:
> A recent patch changed some irq routines from inlines to functions.
> These routines are called by the tracer code. Now that they're functions,
> if they are compiled for function tracing they will call the tracer
> and crash the system due to infinite recursion. The fix disables
> tracing in these functions by using "notrace" in the function
> definition.
>
> Signed-off-by: Al Cooper <alcooperx@...il.com>

Makes sense,

Reviewed-by: David Daney <david.daney@...ium.com>


> ---
>   arch/mips/lib/mips-atomic.c |    8 ++++----
>   1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/mips/lib/mips-atomic.c b/arch/mips/lib/mips-atomic.c
> index e091430..cd160be 100644
> --- a/arch/mips/lib/mips-atomic.c
> +++ b/arch/mips/lib/mips-atomic.c
> @@ -56,7 +56,7 @@ __asm__(
>   	"	.set	pop						\n"
>   	"	.endm							\n");
>
> -void arch_local_irq_disable(void)
> +notrace void arch_local_irq_disable(void)
>   {
.
.
.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/