linux-kernel - Re: [PATCH] x86, microcode, AMD: Add support for family 16h processors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50A57C35.10906@amd.com>
Date:	Thu, 15 Nov 2012 18:35:17 -0500
From:	Boris Ostrovsky <boris.ostrovsky@....com>
To:	Gene Heskett <gheskett@...v.com>
CC:	Henrique de Moraes Holschuh <hmh@....eng.br>, <hpa@...or.com>,
	<mingo@...e.hu>, <tglx@...utronix.de>,
	<herrmann.der.user@...glemail.com>, <bp@...en8.de>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86, microcode, AMD: Add support for family 16h processors



On 11/15/2012 06:01 PM, Gene Heskett wrote:
> On Thursday 15 November 2012, Henrique de Moraes Holschuh wrote:
>> On Thu, 15 Nov 2012, Boris Ostrovsky wrote:
>>> Add valid patch size for family 16h processors
>>>
>>> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@....com>
>>
>> Is this something that needs to go to -stable ?
>
> IMO, and if I had an oar in this water, yes.  Its been missing since the
> Intel folks started playing with it a couple years back up the log.  I
> have the amd_ucode files in my /lib/firmware tree,
>
> root@...ote:/opt/os9# ls -l /lib/firmware/amd-ucode/
> total 76
> -rw-r--r-- 1 root root   642 2012-01-17 11:50 INSTALL
> -rw-r--r-- 1 root root  9987 2012-01-17 11:50 LICENSE
> -rw-r--r-- 1 root root 12404 2012-01-17 11:50 microcode_amd.bin
> -rw-r--r-- 1 root root  1526 2012-01-17 11:50 microcode_amd.bin.README
> -rw-r--r-- 1 root root  2644 2012-01-17 11:50 microcode_amd_fam15h.bin
> -rw-r--r-- 1 root root   510 2012-01-17 11:50
> microcode_amd_fam15h.bin.README
> -rw-r--r-- 1 root root  2012 2009-01-20 04:48 microcode_amd.phenom-V83
> -rw-r--r-- 1 root root 15020 2012-01-17 11:50 microcode_amd_solaris.bin
> -rw-r--r-- 1 root root  1685 2012-01-17 11:50
> microcode_amd_solaris.bin.README
> -rw-r--r-- 1 root root  6227 2012-01-17 11:50 README
>
> but I can't recall the last time I saw the code sign in during dmesg.
> Old, slow 4 core phenom here.  AMD was forgotten about when the loading
> of it was moved from the kernel options to /etc/init.d/microcode.  For
> an AMD user, that was not a show stopper, but it wasn't a Good Thing(TM)
> either.

One possibility is that BIOS already incorporated all patches (which 
typically is the case) and so the driver doesn't have to do anything.

-boris


>
>>
>>>   #define F1XH_MPB_MAX_SIZE 2048
>>>   #define F14H_MPB_MAX_SIZE 1824
>>>   #define F15H_MPB_MAX_SIZE 4096
>>>
>>> +#define F16H_MPB_MAX_SIZE 3458
>>>
>>>   	switch (c->x86) {
>>>
>>>   	case 0x14:
>>> @@ -198,6 +199,9 @@ static unsigned int verify_patch_size(int cpu, u32
>>> patch_size,
>>>
>>>   	case 0x15:
>>>   		max_size = F15H_MPB_MAX_SIZE;
>>>   		break;
>>>
>>> +	case 0x16:
>>> +		max_size = F16H_MPB_MAX_SIZE;
>>> +		break;
>>>
>>>   	default:
>>>   		max_size = F1XH_MPB_MAX_SIZE;
>>>   		break;
>>
>> Because it looks like without this patch, some valid microcode updates
>> would be rejected by the kernel...
>
>
> Cheers, Gene
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/