linux-kernel - Re: [PATCH 02/12] VMCI: datagram implementation.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121115234714.GA8005@kroah.com>
Date:	Thu, 15 Nov 2012 15:47:14 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	George Zhang <georgezhang@...are.com>
Cc:	linux-kernel@...r.kernel.org,
	virtualization@...ts.linux-foundation.org, pv-drivers@...are.com
Subject: Re: [PATCH 02/12] VMCI: datagram implementation.

On Wed, Nov 07, 2012 at 10:41:26AM -0800, George Zhang wrote:
> +/*
> + * Create a datagram entry given a handle pointer.
> + */
> +static int dg_create_handle(u32 resource_id,
> +			    u32 flags,
> +			    u32 priv_flags,
> +			    vmci_datagram_recv_cb recv_cb,
> +			    void *client_data, struct vmci_handle *out_handle)
> +{
> +	int result;
> +	u32 context_id;
> +	struct vmci_handle handle;
> +	struct datagram_entry *entry;
> +
> +	BUG_ON(!recv_cb);
> +	BUG_ON(!out_handle);
> +	BUG_ON(priv_flags & ~VMCI_PRIVILEGE_ALL_FLAGS);

Given that this is a static function, there's no need for these
"asserts", right?  Please send a follow-on patch removing all BUG_ON()
calls from these files, it's not acceptable to crash a user's box from a
driver that is handling parameters _you_ are feeding it.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/