linux-kernel - Re: [PATCH 1/5] ata: suspend/resume callbacks should be conditionally compiled on CONFIG_PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <50A5D39B.4090007@pobox.com>
Date:	Fri, 16 Nov 2012 00:48:11 -0500
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Yuanhan Liu <yuanhan.liu@...ux.intel.com>
CC:	linux-kernel@...r.kernel.org,
	Viresh Kumar <viresh.linux@...il.com>,
	linux-ide@...r.kernel.org, Fengguang Wu <fengguang.wu@...el.com>
Subject: Re: [PATCH 1/5] ata: suspend/resume callbacks should be conditionally
 compiled on CONFIG_PM_SLEEP

On 10/16/2012 10:59 AM, Yuanhan Liu wrote:
> This will fix warnings like following when CONFIG_PM_SLEEP is not set:
>
>          warning: 'xxx_suspend' defined but not used [-Wunused-function]
>          warning: 'xxx_resume' defined but not used [-Wunused-function]
>
> Because
> 	SET_SYSTEM_SLEEP_PM_OPS(suspend_fn, resume_fn)
>
> Only references the callbacks on CONFIG_PM_SLEEP (instead of CONFIG_PM).
>
> Cc: Jeff Garzik <jgarzik@...ox.com>
> Cc: Viresh Kumar <viresh.linux@...il.com>
> Cc: linux-ide@...r.kernel.org
> Signed-off-by: Yuanhan Liu <yuanhan.liu@...ux.intel.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
> ---
>   drivers/ata/ahci_platform.c  |    2 +-
>   drivers/ata/pata_arasan_cf.c |    2 +-
>   drivers/ata/sata_highbank.c  |    2 +-
>   3 files changed, 3 insertions(+), 3 deletions(-)


applied



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/