linux-kernel - Re: [PATCH 20/21] mm: drop vmtruncate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50A5DFA4.2030700@gmail.com>
Date:	Fri, 16 Nov 2012 14:39:32 +0800
From:	Jaegeuk Hanse <jaegeuk.hanse@...il.com>
To:	Marco Stornelli <marco.stornelli@...il.com>
CC:	Linux FS Devel <linux-fsdevel@...r.kernel.org>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 20/21] mm: drop vmtruncate

On 11/03/2012 05:32 PM, Marco Stornelli wrote:
> Removed vmtruncate

Hi Marco,

Could you explain me why vmtruncate need remove? What's the problem and 
how to substitute it?

Regards,
Jaegeuk

>
> Signed-off-by: Marco Stornelli <marco.stornelli@...il.com>
> ---
>   include/linux/mm.h |    1 -
>   mm/truncate.c      |   23 -----------------------
>   2 files changed, 0 insertions(+), 24 deletions(-)
>
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index fa06804..95f70bb 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -977,7 +977,6 @@ static inline void unmap_shared_mapping_range(struct address_space *mapping,
>   
>   extern void truncate_pagecache(struct inode *inode, loff_t old, loff_t new);
>   extern void truncate_setsize(struct inode *inode, loff_t newsize);
> -extern int vmtruncate(struct inode *inode, loff_t offset);
>   void truncate_pagecache_range(struct inode *inode, loff_t offset, loff_t end);
>   int truncate_inode_page(struct address_space *mapping, struct page *page);
>   int generic_error_remove_page(struct address_space *mapping, struct page *page);
> diff --git a/mm/truncate.c b/mm/truncate.c
> index d51ce92..c75b736 100644
> --- a/mm/truncate.c
> +++ b/mm/truncate.c
> @@ -577,29 +577,6 @@ void truncate_setsize(struct inode *inode, loff_t newsize)
>   EXPORT_SYMBOL(truncate_setsize);
>   
>   /**
> - * vmtruncate - unmap mappings "freed" by truncate() syscall
> - * @inode: inode of the file used
> - * @newsize: file offset to start truncating
> - *
> - * This function is deprecated and truncate_setsize or truncate_pagecache
> - * should be used instead, together with filesystem specific block truncation.
> - */
> -int vmtruncate(struct inode *inode, loff_t newsize)
> -{
> -	int error;
> -
> -	error = inode_newsize_ok(inode, newsize);
> -	if (error)
> -		return error;
> -
> -	truncate_setsize(inode, newsize);
> -	if (inode->i_op->truncate)
> -		inode->i_op->truncate(inode);
> -	return 0;
> -}
> -EXPORT_SYMBOL(vmtruncate);
> -
> -/**
>    * truncate_pagecache_range - unmap and remove pagecache that is hole-punched
>    * @inode: inode
>    * @lstart: offset of beginning of hole

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/