Message-ID: <1353049393.7748.156.camel@jerome.southpole.se>
Date:	Fri, 16 Nov 2012 08:03:13 +0100
From:	Jonas Bonn <jonas@...thpole.se>
To:	shuah.khan@...com
Cc:	Marek Szyprowski <m.szyprowski@...sung.com>,
	LKML <linux-kernel@...r.kernel.org>, shuahkhan@...il.com,
	linux-arch@...r.kernel.org
Subject: Re: [PATCH RFT RESEND linux-next] openrisc: dma-mapping: support
 debug_dma_mapping_error

On Thu, 2012-11-15 at 11:00 -0700, Shuah Khan wrote:
> On Fri, 2012-10-26 at 10:05 -0600, Shuah Khan wrote:
> > Add support for debug_dma_mapping_error() call to avoid warning from
> > debug_dma_unmap() interface when it checks for mapping error checked
> > status. Without this patch, device driver failed to check map error
> > warning is generated.
> > 
> > Signed-off-by: Shuah Khan <shuah.khan@...com>
> > ---
> >  arch/openrisc/include/asm/dma-mapping.h |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/openrisc/include/asm/dma-mapping.h b/arch/openrisc/include/asm/dma-mapping.h
> > index fab8628..f12de49 100644
> > --- a/arch/openrisc/include/asm/dma-mapping.h
> > +++ b/arch/openrisc/include/asm/dma-mapping.h
> > @@ -95,6 +95,7 @@ static inline int dma_supported(struct device *dev, u64 dma_mask)
> >  
> >  static inline int dma_mapping_error(struct device *dev, dma_addr_t dma_addr)
> >  {
> > +	debug_dma_mapping_error(dev, dma_addr);
> >  	return 0;
> >  }
> >  
> 
> Marek/Jonas,
> 
> This one is for openrisc to go through Marek's tree with the other arch
> debug_dma_mapping_error() patches. Hoping it is ok with Jonas.

NAK... for a bunch of reasons.

i)   You've sent this exact patch 4 times already... and this time
you're trying to bypass me altogether by going through some other tree.
First it was a PATCH, now it's an RFT... what do you want me to do with
this?

ii)  There isn't enough information in the commit message to understand
what's going on here.  Why do I suddenly need this when I never needed
it before?

iii) This doesn't compile... but I figured out that it depends on other
changes that seem to have snuck into linux-next already.  linux-arch was
never included in that discussion, despite the fact that you have now
introduced warnings for everybody

iv)  From what I can tell, you haven't even attempted to fix all
architectures... but I could be wrong, see next comment.

v)  You've sent this patch series per-architecture which really only
serves to fragment the discussion.  When a change is this
straight-forward (exact same change in each architecture), then it's
better to consolidate everything into a single patch to allow a single
discussion to take place.  As it stands now, I have to go rummaging
through the threads of all 30 architectures to see what others think of
this; I'd say the silence is telling, but the few responses you did
receive all show the same confusion and you're answering the same
questions over and over.  I realize that you can't inflate your patch
statistics this way and you'll probably just miss the top 10 of "Who
wrote 3.8" because of it, but you can always try to write something
witty in your commit message and hope to make "Quotes of the week"
instead.

vi)  If you _had_ requested comment on your underlying dma-debug patch
on linux-arch, I think you would have found that:

1)  introducing warnings without fixing them _at the same time_ isn't OK
when the fix is this simple
2)  if you make changes to core code, you make it optional until all
arches have caught up
3)  you are using get_dma_ops which isn't even implemented on every
architecture
4)  this change probably doesn't belong in every architecture but should
be centralized in more generic code

/Jonas

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists