linux-kernel - Re: [PATCH 11/12] VMCI: host side driver implementation.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121116000331.GA13149@kroah.com>
Date:	Thu, 15 Nov 2012 16:03:31 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	George Zhang <georgezhang@...are.com>
Cc:	linux-kernel@...r.kernel.org,
	virtualization@...ts.linux-foundation.org, pv-drivers@...are.com
Subject: Re: [PATCH 11/12] VMCI: host side driver implementation.

On Wed, Nov 07, 2012 at 10:42:53AM -0800, George Zhang wrote:
> +/*
> + * Sets up a given context for notify to work.  Calls drv_map_bool_ptr()
> + * which maps the notify boolean in user VA in kernel space.
> + */
> +static int vmci_host_setup_notify(struct vmci_ctx *context,
> +				  unsigned long uva)
> +{
> +	struct page *page;
> +	int retval;
> +
> +	if (context->notify_page) {
> +		pr_devel("%s: Notify mechanism is already set up.\n", __func__);
> +		return VMCI_ERROR_DUPLICATE_ENTRY;
> +	}
> +
> +	if (!access_ok(VERIFY_WRITE, (void __user *)uva, sizeof(bool)))
> +		return VMCI_ERROR_GENERIC;

This line causes sparse to complain.  The odds that userspace knows what
gcc is using for "bool" is pretty low.

Please fix.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/