linux-kernel - [PATCH 26/43] mm: numa: Only mark a PMD pmd_numa if the pages are all on the same node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 16 Nov 2012 11:22:36 +0000
From:	Mel Gorman <mgorman@...e.de>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Andrea Arcangeli <aarcange@...hat.com>,
	Ingo Molnar <mingo@...nel.org>
Cc:	Rik van Riel <riel@...hat.com>,
	Johannes Weiner <hannes@...xchg.org>,
	Hugh Dickins <hughd@...gle.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux-MM <linux-mm@...ck.org>,
	LKML <linux-kernel@...r.kernel.org>, Mel Gorman <mgorman@...e.de>
Subject: [PATCH 26/43] mm: numa: Only mark a PMD pmd_numa if the pages are all on the same node

When a pmd_numa fault is handled, all PTEs are treated as if the current
CPU had referenced them and handles it as one fault. This effectively
batches the ptl but loses precision. This patch will only set the PMD
pmd_numa if the examined pages are all on the same node. If the workload
is converged on a PMD boundary then the batch handling is equivalent.

Signed-off-by: Mel Gorman <mgorman@...e.de>
---
 mm/mempolicy.c |   21 ++++++++++++++++++++-
 1 file changed, 20 insertions(+), 1 deletion(-)

diff --git a/mm/mempolicy.c b/mm/mempolicy.c
index bcaa4fe..ca201e9 100644
--- a/mm/mempolicy.c
+++ b/mm/mempolicy.c
@@ -604,6 +604,8 @@ change_prot_numa_range(struct mm_struct *mm, struct vm_area_struct *vma,
 	spinlock_t *ptl;
 	int ret = 0;
 	int nr_pte_updates = 0;
+	bool all_same_node = true;
+	int last_nid = -1;
 
 	VM_BUG_ON(address & ~PAGE_MASK);
 
@@ -662,6 +664,7 @@ change_prot_numa_range(struct mm_struct *mm, struct vm_area_struct *vma,
 	for (_address = address, _pte = pte; _address < end;
 	     _pte++, _address += PAGE_SIZE) {
 		pte_t pteval = *_pte;
+		int this_nid;
 		if (!pte_present(pteval))
 			continue;
 		if (pte_numa(pteval))
@@ -669,6 +672,18 @@ change_prot_numa_range(struct mm_struct *mm, struct vm_area_struct *vma,
 		page = vm_normal_page(vma, _address, pteval);
 		if (unlikely(!page))
 			continue;
+
+		/*
+		 * Check if all pages within the PMD are on the same node. This
+		 * is an approximation as existing pte_numa pages are not
+		 * examined.
+		 */
+		this_nid = page_to_nid(page);
+		if (last_nid == -1)
+			last_nid = this_nid;
+		if (last_nid != this_nid)
+			all_same_node = false;
+
 		/* only check non-shared pages */
 		if (page_mapcount(page) != 1)
 			continue;
@@ -681,7 +696,11 @@ change_prot_numa_range(struct mm_struct *mm, struct vm_area_struct *vma,
 	}
 	pte_unmap_unlock(pte, ptl);
 
-	if (ret && !pmd_numa(*pmd)) {
+	/*
+	 * If all the pages within the PMD are on the same node then mark
+	 * the PMD so it is handled in one fault when next referenced.
+	 */
+	if (all_same_node && !pmd_numa(*pmd)) {
 		spin_lock(&mm->page_table_lock);
 		set_pmd_at(mm, address, pmd, pmd_mknuma(*pmd));
 		spin_unlock(&mm->page_table_lock);
-- 
1.7.9.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/