linux-kernel - Re: [RESEND PATCH v3 1/4] i2c: introduce i2c-cbus driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121116113014.GA19028@pengutronix.de>
Date:	Fri, 16 Nov 2012 12:30:14 +0100
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	Aaro Koskinen <aaro.koskinen@....fi>
Cc:	linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-i2c@...r.kernel.org
Subject: Re: [RESEND PATCH v3 1/4] i2c: introduce i2c-cbus driver

On Mon, Nov 12, 2012 at 09:08:42PM +0200, Aaro Koskinen wrote:
> Add i2c driver to enable access to devices behind CBUS on Nokia Internet
> Tablets.
> 
> The patch also adds CBUS I2C configuration for N8x0 which is one of the
> users of this driver.
> 
> Cc: linux-i2c@...r.kernel.org
> Acked-by: Felipe Balbi <balbi@...com>
> Acked-by: Tony Lindgren <tony@...mide.com>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@....fi>
> Cc: Wolfram Sang <w.sang@...gutronix.de>

Mostly good, but the devicetree binding description is missing.
Please add a proper file with the same name as the driver to
Documentation/devicetree/bindings/i2c.
Also, it might make sense to rename the driver to i2c-cbus-gpio?

Thanks,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)