linux-kernel - Re: [PATCH] staging: Add SystemBase Multi-2/PCI driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1353071875.7586.5.camel@gandalf.local.home>
Date:	Fri, 16 Nov 2012 08:17:55 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	LKML <linux-kernel@...r.kernel.org>, hjchoi <hjchoi@...bas.com>
Subject: Re: [PATCH] staging: Add SystemBase Multi-2/PCI driver

On Thu, 2012-11-15 at 21:08 -0800, Greg Kroah-Hartman wrote:
> On Thu, Nov 15, 2012 at 11:39:31PM -0500, Steven Rostedt wrote:
> > I ported the driver supplied by SystemBase to mainline.
> > 
> > As the driver had MODULE_LICENSE("GPL") it is declared as a GPL module
> > and thus I have the right to distribute it upstream. Note, I did the
> > bare minimum to get it working. It still needs a lot of loving.
> 
> Being in staging only requires 2 things, proper license, and it has to
> build.
> 
> This fails on the second one:
> 
> In file included from drivers/staging/sb105x/sb_pci_mp.c:1:0:
> drivers/staging/sb105x/sb_pci_mp.h:279:40: error: array type has incomplete element type
> drivers/staging/sb105x/sb_pci_mp.c: In function ‘mp_startup’:
> drivers/staging/sb105x/sb_pci_mp.c:546:26: error: invalid type argument of ‘->’ (have ‘struct ktermios’)
> drivers/staging/sb105x/sb_pci_mp.c: In function ‘mp_shutdown’:
> drivers/staging/sb105x/sb_pci_mp.c:573:40: error: invalid type argument of ‘->’ (have ‘struct ktermios’)
> drivers/staging/sb105x/sb_pci_mp.c: In function ‘mp_change_speed’:
> drivers/staging/sb105x/sb_pci_mp.c:596:14: error: wrong type argument to unary exclamation mark
> drivers/staging/sb105x/sb_pci_mp.c:599:10: error: incompatible types when assigning to type ‘struct ktermios *’ from type ‘struct ktermios’
> drivers/staging/sb105x/sb_pci_mp.c: In function ‘mp_throttle’:
> drivers/staging/sb105x/sb_pci_mp.c:734:18: error: invalid type argument of ‘->’ (have ‘struct ktermios’)
> drivers/staging/sb105x/sb_pci_mp.c: In function ‘mp_unthrottle’:
> drivers/staging/sb105x/sb_pci_mp.c:750:18: error: invalid type argument of ‘->’ (have ‘struct ktermios’)
> drivers/staging/sb105x/sb_pci_mp.c: In function ‘mp_set_termios’:
> drivers/staging/sb105x/sb_pci_mp.c:1277:35: error: invalid type argument of ‘->’ (have ‘struct ktermios’)
> drivers/staging/sb105x/sb_pci_mp.c:1282:4: error: invalid type argument of ‘->’ (have ‘struct ktermios’)
> drivers/staging/sb105x/sb_pci_mp.c: In function ‘mp_update_termios’:
> drivers/staging/sb105x/sb_pci_mp.c:1450:19: error: invalid type argument of ‘->’ (have ‘struct ktermios’)
> drivers/staging/sb105x/sb_pci_mp.c: In function ‘mp_block_til_ready’:
> drivers/staging/sb105x/sb_pci_mp.c:1476:24: error: invalid type argument of ‘->’ (have ‘struct ktermios’)
> drivers/staging/sb105x/sb_pci_mp.c:1481:25: error: invalid type argument of ‘->’ (have ‘struct ktermios’)
> drivers/staging/sb105x/sb_pci_mp.c: In function ‘multi_type’:
> drivers/staging/sb105x/sb_pci_mp.c:2763:14: error: bit-field ‘<anonymous>’ width not an integer constant
> In file included from drivers/staging/sb105x/sb_pci_mp.c:1:0:
> drivers/staging/sb105x/sb_pci_mp.c: At top level:
> drivers/staging/sb105x/sb_pci_mp.h:279:40: warning: ‘uart_config’ defined but not used [-Wunused-variable]
> drivers/staging/sb105x/sb_pci_mp.c: In function ‘multi_type’:
> drivers/staging/sb105x/sb_pci_mp.c:2766:1: warning: control reaches end of non-void function [-Wreturn-type]
> make[3]: *** [drivers/staging/sb105x/sb_pci_mp.o] Error 1
> make[2]: *** [drivers/staging/sb105x] Error 2
> make[1]: *** [drivers/staging] Error 2

Ah interesting, probably a missing dependency. Do you have a config I
can test against. It worked for me against 3.6.6 (the kernel that runs
the box with the card).

> 
> Care to redo this against my staging-next tree, or, even better,
> linux-next, which contains a bunch of tty changes in it?

Sure, and I may try it against a few randconfigs (but forcing this
driver enabled, as ktest allows for that ;-)

> 
> Or, if you want, I can take a whack at it to get it to build properly,
> whichever is easier for you.

Of course it would be easier for me to have you do it :-)  But you
already have enough on your plate. I'll get it done, as I may be the
only person using this card.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/