linux-kernel - Re: [PATCH 5/6] dma: ipu_idmac: reuse is_slave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121116135651.GB18920@arwen.pp.htv.fi>
Date:	Fri, 16 Nov 2012 15:56:52 +0200
From:	Felipe Balbi <balbi@...com>
To:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
CC:	Vinod Koul <vinod.koul@...el.com>,
	spear-devel <spear-devel@...t.st.com>,
	<linux-kernel@...r.kernel.org>,
	Viresh Kumar <viresh.kumar@...aro.org>,
	Guennadi Liakhovetski <g.liakhovetski@....de>
Subject: Re: [PATCH 5/6] dma: ipu_idmac: reuse is_slave_xfer helper

On Fri, Nov 16, 2012 at 03:59:18PM +0200, Andy Shevchenko wrote:

-ENOCOMMITLOG ??

> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Cc: Guennadi Liakhovetski <g.liakhovetski@....de>
> ---
>  drivers/dma/ipu/ipu_idmac.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/ipu/ipu_idmac.c b/drivers/dma/ipu/ipu_idmac.c
> index 6585537..c8d0254 100644
> --- a/drivers/dma/ipu/ipu_idmac.c
> +++ b/drivers/dma/ipu/ipu_idmac.c
> @@ -1347,7 +1347,7 @@ static struct dma_async_tx_descriptor *idmac_prep_slave_sg(struct dma_chan *chan
>  	    chan->chan_id != IDMAC_IC_7)
>  		return NULL;
>  
> -	if (direction != DMA_DEV_TO_MEM && direction != DMA_MEM_TO_DEV) {
> +	if (!is_slave_xfer(direction)) {
>  		dev_err(chan->device->dev, "Invalid DMA direction %d!\n", direction);
>  		return NULL;
>  	}
> -- 
> 1.7.10.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)