[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <876255bluf.fsf@octavius.laptop.org>
Date: Fri, 16 Nov 2012 10:37:12 -0500
From: Chris Ball <cjb@...top.org>
To: Trey Ramsay <tramsay@...ux.vnet.ibm.com>
Cc: <linux-kernel@...r.kernel.org>, <linux-mmc@...r.kernel.org>,
Rich Rattanni <rattanni@...il.com>,
Radovan Lekanovic <lekanovic@...il.com>
Subject: Re: [PATCH 1/1] mmc: Bad device can cause mmc driver to hang
Hi Trey,
On Fri, Nov 16 2012, Trey Ramsay wrote:
> There are infinite loops in the mmc code that can be caused by bad hardware.
> The code will loop forever if the device never comes back from program mode,
> R1_STATE_PRG, and it is not ready for data, R1_READY_FOR_DATA.
>
> A long timeout will be added to prevent the code from looping forever.
> The timeout will occur if the device never comes back from program
> state or the device never becomes ready for data.
>
> Signed-off-by: Trey Ramsay <tramsay@...ux.vnet.ibm.com>
Thanks, looks good!
Have you thought about what's going to happen after this path is hit?
Are we just going to start a new request that begins a new ten-minute
hang, or do we notice the bad card state somewhere and refuse to start
new I/O?
- Chris.
--
Chris Ball <cjb@...top.org> <http://printf.net/>
One Laptop Per Child
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists