linux-kernel - Re: [PATCH] autofs4 - use simple_empty() for empty directory check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFx-9A0xknhX7z9KmLAoGMf5GXhuFgroZUixHtevGAFsOQ@mail.gmail.com>
Date:	Fri, 16 Nov 2012 07:45:29 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Ian Kent <ikent@...hat.com>
Cc:	Kernel Mailing List <linux-kernel@...r.kernel.org>,
	autofs mailing list <autofs@...r.kernel.org>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	Al Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH] autofs4 - use simple_empty() for empty directory check

On Thu, Nov 15, 2012 at 8:15 PM, Ian Kent <ikent@...hat.com> wrote:
>
> +static inline int __simple_empty(struct dentry *dentry)
> +{

This seems completely bogus.

It's a duplicate of the existing fs/libfs.c "simple_empty()" function,
but without taking the outer lock.

That kind of code duplication - and doing it in a totally different
file, and making it look autofs-specific - seems entirely wrong.

                      Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/