linux-kernel - Re: [PATCH 1/3] staging: wlags49_h2: ap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALqZ13tK9Dgt3sBYUAbEmNKenOguHsXV9HNZABz7S=vMP6poUQ@mail.gmail.com>
Date:	Fri, 16 Nov 2012 19:07:48 +0200
From:	Johan Meiring <johanmeiring@...il.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	pe1dnn@...at.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] staging: wlags49_h2: ap_h2: fixes coding style issues

Hi Greg,

Thanks for the feedback.  Lesson learned, will remember to do things
in smaller increments and also wrap lines better.

Kindly disregard all three patches.

I'll redo and resend soon :)

Johan

On 16 November 2012 19:05, Greg KH <gregkh@...uxfoundation.org> wrote:
> On Fri, Nov 16, 2012 at 06:52:39PM +0200, Johan Meiring wrote:
>> This corrects several instances of spaces before tabs and incorrect spacing around "*" characters.  It also fixes some 80+ character line length issues, but the majority of such cases have been left as is, as this was probably the author's intention.
>
> Please wrap your changelog lines at the properly length (i.e. 72
> columns)
>
> Also, please only do one thing per patch.  You are doing multiple things
> here, which makes it hard to review.
>
> Same goes for the other patches in this series, please break it up into
> smaller steps, which makes for more patches, but it makes it easier to
> review to ensure you didn't do something wrong.
>
> Care to redo this and resend it?
>
> thanks,
>
> greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/