linux-kernel - Re: [PATCH ] tbfadt.c: output warning only when 64bit 32bit address of FACS/DSDT all have value but not equal to each other

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABawtvPNmOzgvsg9+y12a5ToCmV4OgKQeBAVQeRyc0F+XWmb7Q@mail.gmail.com>
Date:	Fri, 16 Nov 2012 10:28:44 +0800
From:	Ethan Zhao <ethan.kernel@...il.com>
To:	"Moore, Robert" <robert.moore@...el.com>
Cc:	"Brown, Len" <len.brown@...el.com>,
	"Zheng, Lv" <lv.zheng@...el.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH ] tbfadt.c: output warning only when 64bit 32bit address
 of FACS/DSDT all have value but not equal to each other

Bob,
       Thanks for your detailed reviewing about the whole possible conditions.
       I.C.  So that is impossible zero value for Xfacs /Xdsdt if
facs/dsdt >0, for they are assigned in acpi_tb_convert_fadt(),  I need
to move my eyes one line code higher to see why it yelled twice
but not using the 32bit address at once in acpi_tb_convert_fadt().
       Do you agree to move the checking code warning  and into
acpi_tb_convert_fadt to make the code more simple and clear ? Or just
keep it for more rework, more bug?


Thanks,
Ethan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/