linux-kernel - Re: [PATCH 8/9] irq_work: Make self-IPIs optable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFTL4hzQ7twJsE_6ou22W1FPZWj+W3hJ95th=2AgXG8SkWB5Dw@mail.gmail.com>
Date:	Fri, 16 Nov 2012 18:33:02 +0100
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Paul Gortmaker <paul.gortmaker@...driver.com>
Subject: Re: [PATCH 8/9] irq_work: Make self-IPIs optable

2012/11/16 Steven Rostedt <rostedt@...dmis.org>:
> On Fri, 2012-11-16 at 03:21 +0100, Frederic Weisbecker wrote:
>>
>>  /*
>>   * Claim the entry so that no one else will poke at it.
>> @@ -68,14 +59,18 @@ void __weak arch_irq_work_raise(void)
>>   */
>>  static void __irq_work_queue(struct irq_work *work)
>>  {
>> -     bool empty;
>> -
>>       preempt_disable();
>>
>> -     empty = llist_add(&work->llnode, &__get_cpu_var(irq_work_list));
>> -     /* The list was empty, raise self-interrupt to start processing. */
>> -     if (empty)
>> -             arch_irq_work_raise();
>> +     llist_add(&work->llnode, &__get_cpu_var(irq_work_list));
>> +
>> +     /*
>> +      * If the work is flagged as "lazy", just wait for the next tick
>> +      * to run it. Otherwise, or if the tick is stopped, raise the irq work.
>
> Speaking more Greek? ;-)
>
> How about:
>
>         If the work is not "lazy" or the tick is stopped, raise the irq
>         work interrupt (if supported by the arch), otherwise, just wait
>         for the next tick.

Much better :)

>
> Other than that, Acked-by: Steven Rostedt <rostedt@...dmis.org>

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/