linux-kernel - Re: [PATCH] ipack: move header files to include/linux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1353088388.4563.52.camel@fourier.local.igalia.com>
Date:	Fri, 16 Nov 2012 18:53:08 +0100
From:	Samuel Iglesias Gonsálvez 
	<siglesias@...lia.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	devel@...verdev.osuosl.org, jens.taprogge@...rogge.org,
	linux-kernel@...r.kernel.org,
	industrypack-devel@...ts.sourceforge.net
Subject: Re: [PATCH] ipack: move header files to include/linux

On Fri, 2012-11-16 at 18:48 +0100, Samuel Iglesias Gonsálvez wrote:
> On Fri, 2012-11-16 at 09:44 -0800, Greg Kroah-Hartman wrote:
> > On Fri, Nov 16, 2012 at 06:34:36PM +0100, Samuel Iglesias Gonsalvez wrote:
> > > Move ipack header files to include/linux/ directory where they belong to.
> > > 
> > > Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@...lia.com>
> > > ---
> > >  drivers/ipack/carriers/tpci200.h |    3 +-
> > >  drivers/ipack/devices/ipoctal.c  |    2 +-
> > >  drivers/ipack/ipack.c            |    2 +-
> > >  drivers/ipack/ipack.h            |  215 --------------------------------------
> > >  drivers/ipack/ipack_ids.h        |   32 ------
> > >  include/linux/ipack.h            |  214 +++++++++++++++++++++++++++++++++++++
> > >  include/linux/ipack_ids.h        |   32 ++++++
> > >  7 files changed, 249 insertions(+), 251 deletions(-)
> > >  delete mode 100644 drivers/ipack/ipack.h
> > >  delete mode 100644 drivers/ipack/ipack_ids.h
> > >  create mode 100644 include/linux/ipack.h
> > >  create mode 100644 include/linux/ipack_ids.h
> > 
> > Can you send me a patch in -M format, that just shows the files moving
> > next time?
> 
> OK
> 
> > Also, do we really need the ipack_ids.h file in include/linux?  It looks
> > like only the core ipack code cares about the values there, right?
> > 
> 
> Yes, you are right. I will rewrite the patch again and send it.

Looking at the code, 'drivers/ipack/devices/ipoctal.c' needs
IPACK1_DEVICE_ID_SBS_OCTAL_* and IPACK_ID_VERSION_1 constants defined in
ipack_ids.h file.

Is it better to keep ipack_ids.h file in include/linux/ or change the
#include sentence?

Cheers,

Sam


Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)