linux-kernel - Re: PROBLEM: REGRESSION in drivers/platform/x86/dell-laptop.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50A92935.5070802@broadcom.com>
Date:	Sun, 18 Nov 2012 19:30:13 +0100
From:	"Arend van Spriel" <arend@...adcom.com>
To:	"Mark Ellis" <m@...llis.com>
cc:	linux-kernel@...r.kernel.org,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"Piotr Haber" <phaber@...adcom.com>
Subject: Re: PROBLEM: REGRESSION in drivers/platform/x86/dell-laptop.c

On 11/18/2012 11:47 AM, Mark Ellis wrote:
> 1. rfkill code removal causes hang
>
> 2. the rfkill code was removed from this driver in commit
> 53039f222c548bfc119eea6df4dca2b57550e271 this results in my computer
> hanging (dell n5050) if booting with the wireless (hardware) disabled.
> downgrading this module to the version prior to this commit fixes the
> issue.

The commit you mention does not touch dell-laptop.c. The commit before 
that one doe, but it is only adding code. Digging the tree I found this 
one between kernel v3.4 and v3.5-rc1:

commit a6c2390cd6d2083d27a2359658e08f2d3df375ac
Author: Matthew Garrett <mjg@...hat.com>
Date:   Fri Jun 1 12:46:56 2012 -0400

     dell-laptop: Remove rfkill code

     The interface just doesn't work on some machines, and Dell haven't been
     able to tell us either which machines those are or what we should be
     doing instead. This would be fine, except it results in userspace 
ending
     up confused and general sadness. So let's just rip it out for now.

     Signed-off-by: Matthew Garrett <mjg@...hat.com>

Actually, the behavior you describe and given you have a BCM4313 running 
with brcmsmac I may point out that this driver has an issue coming up 
with wireless disabled. This has been fixed in 3.7 kernel so you may 
want to try:

commit 82d8eba358badb466a4e988ecabf0668a8d92e9c
Author: Piotr Haber <phaber@...adcom.com>
Date:   Wed Sep 19 22:21:15 2012 +0200

     brcmsmac: don't start device when RfKill is engaged

     This patch fixes a bug when device is being started
     while RfKill switch is engaged, leading to hang
     due to partial initialization of hardware.

     Tested-by: <dragonn@...pl>
     Reviewed-by: Arend van Spriel <arend@...adcom.com>
     Reviewed-by: Hante Meuleman <meuleman@...adcom.com>
     Signed-off-by: Piotr Haber <phaber@...adcom.com>
     Signed-off-by: Arend van Spriel <arend@...adcom.com>
     Signed-off-by: John W. Linville <linville@...driver.com>

Maybe I should resubmit it to stable. Now there is an idea.

Gr. AvS

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/