linux-kernel - Re: [PATCH] Lib:The patch include fix for "-" during string to long conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20121118140453.2032.qmail@science.horizon.com>
Date:	18 Nov 2012 09:04:53 -0500
From:	"George Spelvin" <linux@...izon.com>
To:	linux@...izon.com, namit2010@...il.com
Cc:	akpm@...ux-foundation.org, andrei.emeltchenko@...el.com,
	andriy.shevchenko@...ux.intel.com, jbeulich@...e.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Lib:The patch include fix for "-" during string to long conversion

Namit Gupta wrote:
> @@ -91,10 +98,18 @@ EXPORT_SYMBOL(simple_strtol);
>   */
>  long long simple_strtoll(const char *cp, char **endp, unsigned int base)
>  {
> 
>      long l;
>  
>      if (cp[0] != '-')
>          return simple_strtoull(cp, endp, base);
>      l = -simple_strtoull(cp+1, endp, base);

In addition to the somewhat ugly the leading blank line,
I'd call this not very well tested.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/