linux-kernel - Re: [PATCH V2] checkpatch: extend line continuation test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <004901cdc5f2$1032e1e0$3098a5a0$%han@samsung.com>
Date:	Mon, 19 Nov 2012 10:06:10 +0900
From:	Jingoo Han <jg1.han@...sung.com>
To:	'Joe Perches' <joe@...ches.com>,
	'Andrew Morton' <akpm@...ux-foundation.org>
Cc:	'Andy Whitcroft' <apw@...onical.com>, peter@...leysoftware.com,
	'LKML' <linux-kernel@...r.kernel.org>,
	'Jingoo Han' <jg1.han@...sung.com>
Subject: Re: [PATCH V2] checkpatch: extend line continuation test

On Saturday, November 17, 2012 4:31 AM, Joe Perches wrote
> 
> Preprocessor directives and asm statements should be
> allowed to have a line continuation.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>


Tested-by: Jingoo Han <jg1.han@...sung.com>

Best regards,
Jingoo Han


> ---
> V2:
> Make the check for preprocessor directives work properly
> # is not optional.
> 
>  scripts/checkpatch.pl |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index d2d5ba1..bfb06ee 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3006,10 +3006,12 @@ sub process {
>  				}
>  			}
> 
> -# check for line continuations outside of #defines
> +# check for line continuations outside of #defines, preprocessor #, and asm
> 
>  		} else {
>  			if ($prevline !~ /^..*\\$/ &&
> +			    $line !~ /^\+\s*\#.*\\$/ &&		# preprocessor
> +			    $line !~ /^\+.*\b(__asm__|asm)\b.*\\$/ &&	# asm
>  			    $line =~ /^\+.*\\$/) {
>  				WARN("LINE_CONTINUATIONS",
>  				     "Avoid unnecessary line continuations\n" . $herecurr);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/