linux-kernel - Re: [PATCH v2] New Nokia RX-51 power supply battery driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5320319.2WmO5VDT8j@pali>
Date:	Mon, 19 Nov 2012 13:18:29 +0100
From:	Pali Rohár <pali.rohar@...il.com>
To:	Anton Vorontsov <cbouatmailru@...il.com>
Cc:	David Woodhouse <dwmw2@...radead.org>,
	linux-kernel@...r.kernel.org,
	Joerg Reisenweber <joerg@...nmoko.org>,
	Ivaylo Dimitrov <freemangordon@....bg>
Subject: Re: [PATCH v2] New Nokia RX-51 power supply battery driver

On Sunday 18 November 2012 15:12:40 Anton Vorontsov wrote:
> On Wed, Oct 31, 2012 at 10:48:40AM +0100, Pali Rohár wrote:
> > Hello, I fixed style issues and added it to Makefile and
> > Kconfig.
> > 
> > power_supply: Add Nokia RX-51 battery driver
> > 
> > This driver exporting battery design capacity, temperature
> > and voltage for battery in Nokia RX-51. This driver is
> > needed for open source battery management on Nokia RX-51
> > (N900).
> > 
> > Signed-off-by: Pali Rohár <pali.rohar@...il.com>
> 
> Looks great, thank you! This is now in the battery git tree.
> 
> p.s.
> 
> fwiw, I added the N900 reference to the user-visible Kconfig
> text:
> 
>  config BATTERY_RX51
> -	tristate "Nokia RX-51 battery driver"
> +	tristate "Nokia RX-51 (N900) battery driver"
>  	depends on TWL4030_MADC
>  	help
> -	  Say Y here to enable support for battery information on
> Nokia RX-51. +	  Say Y here to enable support for battery
> information on Nokia +	  RX-51, also known as N900 tablet.

Ok. Here is missing patch which register this driver in Nokia N900 board code. Without it driver is not loaded.

>From 0b60efd06a71668439bcb761c6572dd7df91dc17 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pali=20Roh=C3=A1r?= <pali.rohar@...il.com>
Date: Mon, 19 Nov 2012 09:05:24 +0100
Subject: [PATCH 1/3] ARM: OMAP: rx51: Register platform device for
 rx51_battery driver
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Pali Rohár <pali.rohar@...il.com>
---
 arch/arm/mach-omap2/board-rx51-peripherals.c |    6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c
index 020e03c..fe1ac7e 100644
--- a/arch/arm/mach-omap2/board-rx51-peripherals.c
+++ b/arch/arm/mach-omap2/board-rx51-peripherals.c
@@ -271,11 +271,17 @@ static struct platform_device rx51_charger_device = {
 	},
 };
 
+static struct platform_device rx51_battery_device = {
+	.name		= "rx51-battery",
+	.id		= -1,
+};
+
 static void __init rx51_charger_init(void)
 {
 	WARN_ON(gpio_request_one(RX51_USB_TRANSCEIVER_RST_GPIO,
 		GPIOF_OUT_INIT_HIGH, "isp1704_reset"));
 
+	platform_device_register(&rx51_battery_device);
 	platform_device_register(&rx51_charger_device);
 }
 
-- 
1.7.10.4

-- 
Pali Rohár
pali.rohar@...il.com
Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)